Update folders names for snippets (Conversation)#239
Merged
asein-sinch merged 3 commits intomainfrom Apr 1, 2026
Merged
Conversation
asein-sinch
requested review from
JPPortier,
matsk-sinch and
rpredescu-sinch
as code owners
JPPortier
reviewed
Apr 1, 2026
JPPortier
left a comment
JPPortier
left a comment
There was a problem hiding this comment.
package.json file need to be updated according to new names: https://github.com/sinch/sinch-sdk-node/blob/Update-snippets-folders-names/examples/snippets/package.json#L13
Do you think we can add some CI validation to detect this in the future ?
Collaborator
Author
Yes, just added a script |
JPPortier
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.