Skip to content

Prepare release 1.4#237

Merged
asein-sinch merged 8 commits intov1.4-nextfrom
Prepare-release-1.4
Mar 31, 2026
Merged

Prepare release 1.4#237
asein-sinch merged 8 commits intov1.4-nextfrom
Prepare-release-1.4

Conversation

@asein-sinch
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@matsk-sinch matsk-sinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Findings

1. Missing CHANGELOG entry for resetClient()resetApiClient() rename

Files: packages/elastic-sip-trunking/CHANGELOG.md, packages/voice/CHANGELOG.md
Severity: 🔴 Critical

The resetClient()resetApiClient() rename (commit a43fc08 on the leftovers-for-1.4 branch) is a breaking change for anyone extending LazyElasticSipTrunkingApiClient, LazyVoiceApiClient, or LazyVoiceApplicationManagementApiClient. This rename should be documented in the EST and Voice CHANGELOGs under [Tech] before release.

2. Missing CHANGELOG entry for Fax model fixes

File: packages/fax/CHANGELOG.md
Severity: 🟠 Medium

Commit 80b9980 ("Small Fax API fixes") adds properties to the Email and ServicePhoneNumber models and updates tests, but the fax CHANGELOG doesn't mention these model changes. Consider adding a [Bugfix] or [Tech] entry so users are aware of the model updates.

Base automatically changed from leftovers-for-1.4 to v1.4-next March 31, 2026 11:52
@asein-sinch
Copy link
Copy Markdown
Collaborator Author

@matsk-sinch

  1. Missing CHANGELOG entry for resetClient() → resetApiClient() rename
    => Won't fix as this feature has not be released yet, this is a change on an on-going development that will surface for the end-user with the 1.4 delivery only.

  2. Missing CHANGELOG entry for Fax model fixes
    => I've updated the changelog file accordingly

@asein-sinch asein-sinch requested a review from matsk-sinch March 31, 2026 12:07
Copy link
Copy Markdown

@matsk-sinch matsk-sinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the way to v1.4 🚀

@asein-sinch asein-sinch merged commit 1355ef4 into v1.4-next Mar 31, 2026
4 checks passed
@asein-sinch asein-sinch deleted the Prepare-release-1.4 branch March 31, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants