Conversation
matsk-sinch
left a comment
There was a problem hiding this comment.
Code Review Findings
1. Missing CHANGELOG entry for resetClient() → resetApiClient() rename
Files: packages/elastic-sip-trunking/CHANGELOG.md, packages/voice/CHANGELOG.md
Severity: 🔴 Critical
The resetClient() → resetApiClient() rename (commit a43fc08 on the leftovers-for-1.4 branch) is a breaking change for anyone extending LazyElasticSipTrunkingApiClient, LazyVoiceApiClient, or LazyVoiceApplicationManagementApiClient. This rename should be documented in the EST and Voice CHANGELOGs under [Tech] before release.
2. Missing CHANGELOG entry for Fax model fixes
File: packages/fax/CHANGELOG.md
Severity: 🟠 Medium
Commit 80b9980 ("Small Fax API fixes") adds properties to the Email and ServicePhoneNumber models and updates tests, but the fax CHANGELOG doesn't mention these model changes. Consider adding a [Bugfix] or [Tech] entry so users are aware of the model updates.
|
No description provided.