Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ jobs:
path: |
${{ runner.workspace }}/b/ninja/simc
ActionPriorityLists
profiles
.git
key: ubuntu-${{ matrix.compiler }}-for_run-${{ github.sha }}-cpp-${{ matrix.cppVersion }}

Expand Down Expand Up @@ -130,7 +129,6 @@ jobs:
path: |
${{ runner.workspace }}/b/ninja/simc
ActionPriorityLists
profiles
.git
key: ubuntu-${{ matrix.compiler }}-for_run-${{ github.sha }}-cpp-${{ matrix.cppVersion }}

Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/generate_files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
path: |
${{ runner.workspace }}/b/ninja/simc
ActionPriorityLists
profiles
.git
key: ubuntu-clang++-15-for_run-${{ github.sha }}-cpp-17

Expand All @@ -36,13 +35,6 @@ jobs:
pattern: apl-${{ github.sha }}-*
merge-multiple: true

- name: Download Profiles
uses: actions/download-artifact@v8
with:
path: profiles
pattern: profiles-${{ github.sha }}-*
merge-multiple: true

- name: Dump Spell Data
if: steps.cache.outputs.cache-hit == 'true'
env:
Expand Down Expand Up @@ -72,4 +64,3 @@ jobs:
with:
name: |
apl-${{ github.sha }}-*
profiles-${{ github.sha }}-*
27 changes: 13 additions & 14 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ on:
- "casc_extract/**"

env:
SIMC_PROFILE: profiles/CI.simc
CCACHE_GENERATION: 0 # bump if you need to "clean" ccache

# Most CI jobs only run if you are either:
Expand Down Expand Up @@ -110,43 +109,43 @@ jobs:
local file="$1"

case "$file" in
engine/class_modules/sc_death_knight.cpp|engine/class_modules/apl/apl_death_knight.*|profiles/generators/*/*_Generate_Deathknight.simc)
engine/class_modules/sc_death_knight.cpp|engine/class_modules/apl/apl_death_knight.*)
mark_class_changed deathknight
;;
engine/class_modules/sc_demon_hunter.cpp|engine/class_modules/apl/apl_demon_hunter.*|engine/class_modules/apl/demon_hunter/*|profiles/generators/*/*_Generate_Demonhunter.simc)
engine/class_modules/sc_demon_hunter.cpp|engine/class_modules/apl/apl_demon_hunter.*|engine/class_modules/apl/demon_hunter/*)
mark_class_changed demonhunter
;;
engine/class_modules/sc_druid.cpp|engine/class_modules/apl/druid/*|profiles/generators/*/*_Generate_Druid.simc)
engine/class_modules/sc_druid.cpp|engine/class_modules/apl/druid/*)
mark_class_changed druid
;;
engine/class_modules/sc_evoker.cpp|engine/class_modules/apl/apl_evoker.*|profiles/generators/*/*_Generate_Evoker.simc)
engine/class_modules/sc_evoker.cpp|engine/class_modules/apl/apl_evoker.*)
mark_class_changed evoker
;;
engine/class_modules/sc_hunter.cpp|engine/class_modules/apl/hunter/*|engine/class_modules/apl/apl_hunter.*|profiles/generators/*/*_Generate_Hunter.simc)
engine/class_modules/sc_hunter.cpp|engine/class_modules/apl/hunter/*|engine/class_modules/apl/apl_hunter.*)
mark_class_changed hunter
;;
engine/class_modules/sc_mage.cpp|engine/class_modules/apl/mage.*|profiles/generators/*/*_Generate_Mage.simc)
engine/class_modules/sc_mage.cpp|engine/class_modules/apl/mage.*)
mark_class_changed mage
;;
engine/class_modules/monk/*|engine/class_modules/apl/apl_monk.*|profiles/generators/*/*_Generate_Monk.simc)
engine/class_modules/monk/*|engine/class_modules/apl/apl_monk.*)
mark_class_changed monk
;;
engine/class_modules/paladin/*|engine/class_modules/apl/apl_paladin.*|profiles/generators/*/*_Generate_Paladin.simc)
engine/class_modules/paladin/*|engine/class_modules/apl/apl_paladin.*)
mark_class_changed paladin
;;
engine/class_modules/priest/*|engine/class_modules/apl/apl_priest.*|profiles/generators/*/*_Generate_Priest.simc)
engine/class_modules/priest/*|engine/class_modules/apl/apl_priest.*)
mark_class_changed priest
;;
engine/class_modules/sc_rogue.cpp|engine/class_modules/apl/rogue/*|engine/class_modules/apl/apl_rogue.*|profiles/generators/*/*_Generate_Rogue.simc)
engine/class_modules/sc_rogue.cpp|engine/class_modules/apl/rogue/*|engine/class_modules/apl/apl_rogue.*)
mark_class_changed rogue
;;
engine/class_modules/sc_shaman.cpp|engine/class_modules/apl/apl_shaman.*|engine/class_modules/apl/shaman/*|profiles/generators/*/*_Generate_Shaman.simc)
engine/class_modules/sc_shaman.cpp|engine/class_modules/apl/apl_shaman.*|engine/class_modules/apl/shaman/*)
mark_class_changed shaman
;;
engine/class_modules/warlock/*|engine/class_modules/apl/warlock.*|profiles/generators/*/*_Generate_Warlock.simc)
engine/class_modules/warlock/*|engine/class_modules/apl/warlock.*)
mark_class_changed warlock
;;
engine/class_modules/sc_warrior.cpp|engine/class_modules/apl/apl_warrior.*|profiles/generators/*/*_Generate_Warrior.simc)
engine/class_modules/sc_warrior.cpp|engine/class_modules/apl/apl_warrior.*)
mark_class_changed warrior
;;
*)
Expand Down
50 changes: 0 additions & 50 deletions .github/workflows/spec_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
path: |
${{ runner.workspace }}/b/ninja/simc
ActionPriorityLists
profiles
.git
key: ${{ inputs.cache-key }}

Expand Down Expand Up @@ -368,52 +367,3 @@ jobs:
path: |
ActionPriorityLists/*/${{ matrix.spec }}.simc
retention-days: 1

- name: Generate Profiles
id: generate_profiles
if: github.event_name == 'push' && !failure() && !inputs.is-ptr
continue-on-error: true
shell: bash
run: |
cd profiles
for dir in generators/*; do
if [ -d $dir ]; then
SEASON=${dir##*/}
GENERATOR=${SEASON}_Generate_${{ env.CLASS_STR_CAP }}.simc
if [ -f $dir/$GENERATOR ]; then
cd $SEASON
echo "---$SEASON---${{ env.CLASS_STR_CAP }}---$GENERATOR---"
${{ runner.workspace }}/b/ninja/simc $dir/$GENERATOR
cd ..
fi
fi
done
- name: Check Profile Changes
id: check_profile_changes
if: steps.generate_profiles.outcome == 'success'
continue-on-error: true
shell: bash
run: |
CHANGED=$(git status --porcelain -- profiles/*/*.simc | sed 's/^...//')
if [ -n "$CHANGED" ]; then
echo "changed=true" >> "$GITHUB_OUTPUT"
echo "Changed profile files:"
echo "$CHANGED"
mkdir -p /tmp/changed_profiles
echo "$CHANGED" | while read -r f; do
cp --parents "$f" /tmp/changed_profiles/
done
else
echo "changed=false" >> "$GITHUB_OUTPUT"
echo "No profile files changed"
fi
- name: Upload Profiles
if: steps.check_profile_changes.outputs.changed == 'true'
continue-on-error: true
uses: actions/upload-artifact@v6
with:
name: profiles-${{ github.sha }}-${{ matrix.spec }}
path: /tmp/changed_profiles/profiles/
retention-days: 1
6 changes: 0 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ initiative and help out wherever needed. GitHub provides considerable utilities
The mantra is: Just check it in. Don't ask for permission. If the code needs to be changed for functional (or artistic!) reasons,
someone will revert/modify as needed.

## Profiles
SimulationCraft includes a set of sample profiles for the current raiding tier, which are located in /profiles.
If you want to improve those profiles, please note to the following:
* Change character profile settings like talents & gear in the files you can find at /profiles/generators.
The files in /profiles are auto-generated and will be overriden.

## Action Priority List (APL)
SimulationCraft includes a set of default action priority lists for each specialization, to offer users a ready-to-use
simulation experience once they import their character. This APL is the main factor defining if a character performs just ok
Expand Down
4 changes: 1 addition & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
# To reduce the footprint of this image all SimulationCraft files are
# removed except:
# - ./simc
# - ./profiles/*
#

# build image
Expand Down Expand Up @@ -75,9 +74,8 @@ RUN \
libgcc \
libstdc++

# get compiled simc and profiles
# get compiled simc
COPY --from=build /app/SimulationCraft/engine/simc /app/SimulationCraft/
COPY --from=build /app/SimulationCraft/profiles/ /app/SimulationCraft/profiles/

WORKDIR /app/SimulationCraft

Expand Down
6 changes: 1 addition & 5 deletions cli/cli.pro
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,11 @@ unix {
# Deployment for Linux
unix:!macx {
DISTFILES += CHANGES COPYING
INSTALLS += target Profiles
INSTALLS += target
# Disable strip
QMAKE_STRIP = echo

target.path = $$DESTDIR$$PREFIX/bin/

Profiles.files = $$files(../profiles/*, recursive=true)
Profiles.path = $$SHAREPATH/profiles
Profiles.commands = @echo Installing profiles to $$SHAREPATH/profiles
}

include(../source_files/QT_engine_main.pri)
Expand Down
11 changes: 3 additions & 8 deletions gui/gui.pro
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ CONFIG(debug, debug|release): LIBS += -L../lib/debug -lsimcengine

Resources.files = ../qt/Welcome.html ../qt/Welcome.png ../qt/Error.html
Localization.files = $$files(../locale/*.qm)
Profiles.files = $$files(../profiles/*, recursive=true)


macx {
Expand All @@ -47,10 +46,9 @@ macx {
}

Resources.path = Contents/Resources
Profiles.path = Contents/Resources/profiles
Localization.path = Contents/Resources/locale

QMAKE_BUNDLE_DATA += Profiles Resources Localization
QMAKE_BUNDLE_DATA += Resources Localization
}

win32 {
Expand All @@ -62,19 +60,16 @@ win32 {
}
}

# Deplopyment for Linux, note, the cli project also copies profiles
# Deplopyment for Linux, note
unix:!macx {

DISTFILES += CHANGES COPYING
INSTALLS += target Profiles Resources icon Localization
INSTALLS += target Resources icon Localization
# Disable strip
QMAKE_STRIP = echo

target.path = $$DESTDIR$$PREFIX/bin/

Profiles.path = $$SHAREPATH/profiles
profiles.commands = @echo Installing profiles to $$SHAREPATH/profiles

Resources.path = $$SHAREPATH
data.commands = @echo Installing global files to $$SHAREPATH

Expand Down
113 changes: 0 additions & 113 deletions profiles/MID1/MID1_Death_Knight_Blood.simc

This file was deleted.

Loading
Loading