POC of subscriptions for notifiable instances#205
Draft
adamsosterics wants to merge 2 commits intosimukappu:masterfrom
Draft
POC of subscriptions for notifiable instances#205adamsosterics wants to merge 2 commits intosimukappu:masterfrom
adamsosterics wants to merge 2 commits intosimukappu:masterfrom
Conversation
This refactor will help us to add targets who are only subscribed for a specific notifiable instance.
This is just a quick proof-of-concept for adding subscriptions to notifiable instances.
2 similar comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #202
Summary
This is a proof-of-concept for implementing subscriptions for specific notifiable instances.
Please let me know what you think, I can make it a proper implementaiton if you like the solution direction.
Other Information