Skip to content

ci: add security-scan + semgrep + dependabot#1

Merged
Cre-eD merged 4 commits intov1from
ci/security-scans
May 7, 2026
Merged

ci: add security-scan + semgrep + dependabot#1
Cre-eD merged 4 commits intov1from
ci/security-scans

Conversation

@Cre-eD
Copy link
Copy Markdown
Contributor

@Cre-eD Cre-eD commented May 7, 2026

Summary

  • Adds 4 wrapper workflows that delegate to simple-container-com/actions:
    • security-scan — TruffleHog + Syft + Trivy + Grype, sticky PR comment, status gate
    • semgrep — SC custom ruleset + optional consumer rules / registry packs, sticky PR comment, status gate
  • Adds .github/dependabot.yml for weekly bumps (github-actions + gomod where applicable, minor+patch grouped)

Trust posture

Scan jobs run on pull_request (not _target), read-only token, no secrets — safe for fork PRs. Comment posting lives in a separate workflow_run-triggered workflow that never reads PR code.

Test plan

  • First scan + comment runs end-to-end
  • Sticky PR comment appears with status table
  • No false positives on the existing codebase

Cre-eD added 2 commits May 7, 2026 16:16
Wires this repo to the org-wide reusable workflows in simple-container-com/actions:
- security-scan: TruffleHog (secrets) + Syft/CycloneDX SBOM + Trivy + Grype, sticky PR comment, status gate
- semgrep: SC custom ruleset + optional consumer rules / registry packs, sticky PR comment, status gate

Both follow the GitHub Security Lab 'preventing pwn requests' split: scan jobs run in pull_request context (read-only token, no secrets, fork-PR safe); comment posting lives in a workflow_run-triggered job that never reads PR code.

Adds .github/dependabot.yml tracking the github-actions ecosystem only (forge-action has no language-specific dependencies yet).
@Cre-eD Cre-eD force-pushed the ci/security-scans branch from bf6a55c to 4eabd70 Compare May 7, 2026 12:30
@Cre-eD Cre-eD self-assigned this May 7, 2026
@Cre-eD Cre-eD force-pushed the ci/security-scans branch from 4eabd70 to 0eabf76 Compare May 7, 2026 12:39
Cre-eD added 2 commits May 7, 2026 16:54
Signed-off-by: Dmitrii Creed <creeed22@gmail.com>
Two ERROR-severity findings from gha-script-injection-via-attacker-controlled-context (Semgrep, on this PR's first scan):

1. .github/actions/dockerless/action.yml:90 — script_version interpolated as a positional arg to acquire-scripts.sh. Pass via env (SCRIPT_VERSION) and reference as "$SCRIPT_VERSION" inside the run block.

2. .github/actions/dockerless/action.yml:139 — multiple inputs (job_id, issue_id, service_url, branch, simple_forge_api_key) interpolated as positional args, plus the simple_forge_api_key debug echo using single-quoted ${{ inputs.simple_forge_api_key }} (would break the quoting if the API key contains an apostrophe). All references replaced with the env-mapped variables already declared in the env: block. The duplicate debug echo was redundant with the API_KEY env-var debug line just below; removed it.

Signed-off-by: Dmitrii Creed <creeed22@gmail.com>
@Cre-eD Cre-eD requested a review from smecsia May 7, 2026 13:26
@Cre-eD Cre-eD merged commit b85c96d into v1 May 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants