SF-3757 Add simplified draft config page as experimental feature#3763
Draft
SF-3757 Add simplified draft config page as experimental feature#3763
Conversation
151ad27 to
e0e3d80
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3763 +/- ##
==========================================
+ Coverage 81.29% 81.31% +0.02%
==========================================
Files 621 624 +3
Lines 39114 39308 +194
Branches 6382 6415 +33
==========================================
+ Hits 31798 31965 +167
- Misses 6331 6344 +13
- Partials 985 999 +14 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new, simplified page for configuring draft sources.
I initially made changes to the draft sources component, moving the content from the left, while keeping the layout of the overview on the right. See diagram below:
During a recent meeting we discussed the best way to get user feedback before rolling this out. It was decided to create a new "Experimental features" system that allows users to turn it on, so that it can be tested with real users and real projects before we roll it out.
I created an experimental features service and dialog that merely exposes certain feature flags through a different UI to allow users to turn them on or off. When no experimental features are available, it's not available in the menu. Some features (such as the new configure sources page) are only available to users that are an admin on at least one project.
Mostly I deleted a lot of code, especially in the template and styles, plus a few things in the component TS file that were no longer used by the template. Unfortunately, copying the component makes it a lot harder for a reviewer to tell what was changed.
This change is