Skip to content

SF-3757 Add simplified draft config page as experimental feature#3763

Draft
Nateowami wants to merge 1 commit intomasterfrom
feature/SF-3757-simplify-draft-config
Draft

SF-3757 Add simplified draft config page as experimental feature#3763
Nateowami wants to merge 1 commit intomasterfrom
feature/SF-3757-simplify-draft-config

Conversation

@Nateowami
Copy link
Copy Markdown
Collaborator

@Nateowami Nateowami commented Mar 27, 2026

This PR creates a new, simplified page for configuring draft sources.

localhost_5000_projects_69c68548c30722fa1ac278c3_draft-generation

I initially made changes to the draft sources component, moving the content from the left, while keeping the layout of the overview on the right. See diagram below:

Screenshot from 2026-03-27 13-39-43

During a recent meeting we discussed the best way to get user feedback before rolling this out. It was decided to create a new "Experimental features" system that allows users to turn it on, so that it can be tested with real users and real projects before we roll it out.

I created an experimental features service and dialog that merely exposes certain feature flags through a different UI to allow users to turn them on or off. When no experimental features are available, it's not available in the menu. Some features (such as the new configure sources page) are only available to users that are an admin on at least one project.

Mostly I deleted a lot of code, especially in the template and styles, plus a few things in the component TS file that were no longer used by the template. Unfortunately, copying the component makes it a lot harder for a reviewer to tell what was changed.


This change is Reviewable

@Nateowami Nateowami added will require testing PR should not be merged until testers confirm testing is complete e2e Run e2e tests for this pull request labels Mar 27, 2026
@Nateowami Nateowami force-pushed the feature/SF-3757-simplify-draft-config branch from 151ad27 to e0e3d80 Compare March 27, 2026 21:07
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 73.00000% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.31%. Comparing base (a5da91d) to head (e0e3d80).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nfigure-sources/new-configure-sources.component.ts 70.93% 37 Missing and 13 partials ⚠️
...ate/draft-generation/draft-generation.component.ts 50.00% 1 Missing and 1 partial ⚠️
...Forge.Scripture/ClientApp/src/app/app.component.ts 50.00% 1 Missing ⚠️
...ientApp/src/xforge-common/user-projects.service.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3763      +/-   ##
==========================================
+ Coverage   81.29%   81.31%   +0.02%     
==========================================
  Files         621      624       +3     
  Lines       39114    39308     +194     
  Branches     6382     6415      +33     
==========================================
+ Hits        31798    31965     +167     
- Misses       6331     6344      +13     
- Partials      985      999      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant