SF-3744 Hide format options button on draft tab when draft started#3762
Open
RaymondLuong3 wants to merge 2 commits intomasterfrom
Open
SF-3744 Hide format options button on draft tab when draft started#3762RaymondLuong3 wants to merge 2 commits intomasterfrom
RaymondLuong3 wants to merge 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3762 +/- ##
==========================================
+ Coverage 81.29% 81.30% +0.01%
==========================================
Files 621 621
Lines 39114 39116 +2
Branches 6382 6355 -27
==========================================
+ Hits 31798 31805 +7
- Misses 6331 6340 +9
+ Partials 985 971 -14 ☔ View full report in Codecov by Sentry. |
2943982 to
78d145d
Compare
78d145d to
39b4b5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the draft tab component to subscribe to the ProjectNotificationService to get updates on completed builds and updates the visibility of the formatting options button based on the status of the latest build. Now the component will update more quickly if a new build is started and the user should not be seeing the formatting options button.
I also removed the dead code from the draft generation page.
This change is