Skip to content

SF-3744 Hide format options button on draft tab when draft started#3762

Open
RaymondLuong3 wants to merge 2 commits intomasterfrom
fix/sf-3744-formatting-options
Open

SF-3744 Hide format options button on draft tab when draft started#3762
RaymondLuong3 wants to merge 2 commits intomasterfrom
fix/sf-3744-formatting-options

Conversation

@RaymondLuong3
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 commented Mar 26, 2026

This PR updates the draft tab component to subscribe to the ProjectNotificationService to get updates on completed builds and updates the visibility of the formatting options button based on the status of the latest build. Now the component will update more quickly if a new build is started and the user should not be seeing the formatting options button.

I also removed the dead code from the draft generation page.


Open with Devin

This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Mar 26, 2026
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (a5da91d) to head (39b4b5c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...late/editor/editor-draft/editor-draft.component.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3762      +/-   ##
==========================================
+ Coverage   81.29%   81.30%   +0.01%     
==========================================
  Files         621      621              
  Lines       39114    39116       +2     
  Branches     6382     6355      -27     
==========================================
+ Hits        31798    31805       +7     
- Misses       6331     6340       +9     
+ Partials      985      971      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 force-pushed the fix/sf-3744-formatting-options branch from 2943982 to 78d145d Compare March 27, 2026 20:16
@RaymondLuong3 RaymondLuong3 force-pushed the fix/sf-3744-formatting-options branch from 78d145d to 39b4b5c Compare March 27, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant