Skip to content

Remove SF_PUSH_KEY from GitHub actions#3760

Merged
Nateowami merged 1 commit intomasterfrom
actions/remove-sf-push-key
Mar 26, 2026
Merged

Remove SF_PUSH_KEY from GitHub actions#3760
Nateowami merged 1 commit intomasterfrom
actions/remove-sf-push-key

Conversation

@Nateowami
Copy link
Copy Markdown
Collaborator

@Nateowami Nateowami commented Mar 25, 2026

When a GitHub action creates a PR, GitHub actions don't run on that PR, because GitHub tries to prevent that type of thing (probably in order to prevent infinite actions, and/or security implications).

A workaround for that is to give an action credentials to act on behalf of a user. I attempted to do that when setting up the workflows that open PRs by using an SSH key as the credential when pushing changes, as this is one of the documented methods in the peter-evans/create-pull-request repo.

Unfortunately this was never successful, and I later discovered that closing and reopening the PR was enough to trigger the workflows.

This PR removes an unneeded secret and brings it in line with our other PR-creating workflows. Once merged, I intend to delete the secret from the repo, so no actions can access it.


Open with Devin

This change is Reviewable

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment on lines 18 to 20
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 GITHUB_TOKEN vs SSH deploy key: CI triggers on created PRs

With the SSH deploy key removed, the workflow now relies on GITHUB_TOKEN for authentication. A well-known difference is that PRs created using GITHUB_TOKEN do not trigger subsequent GitHub Actions workflows (e.g., CI checks), whereas PRs created via a deploy key or PAT do. However, since the other analogous workflows (update-font-list.yml:17-19, update-npm-audit.yml:17-19) already operate without an SSH key and presumably work fine, this is likely an accepted tradeoff in this repository. If CI checks running automatically on the created i18n/update PR branch are important, this could be a concern.

(Refers to lines 17-20)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.29%. Comparing base (3685f14) to head (b655a34).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3760   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files         621      621           
  Lines       39114    39114           
  Branches     6358     6358           
=======================================
  Hits        31798    31798           
  Misses       6344     6344           
  Partials      972      972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 self-assigned this Mar 26, 2026
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I approve. I'll let you merge this so that you remember to delete the secret from the repo as you mentioned.

@RaymondLuong3 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).

@Nateowami Nateowami force-pushed the actions/remove-sf-push-key branch from 3a53ea7 to b655a34 Compare March 26, 2026 17:46
@Nateowami Nateowami merged commit a5da91d into master Mar 26, 2026
23 of 24 checks passed
@Nateowami Nateowami deleted the actions/remove-sf-push-key branch March 26, 2026 19:10
@Nateowami
Copy link
Copy Markdown
Collaborator Author

@RaymondLuong3 Thanks; that was smart thinking. I've deleted the secret and run the workflow to make sure it is still functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants