Skip to content

Fix self-referencing property (unused like others in this class)#282

Merged
Enkidu93 merged 1 commit intomainfrom
fix_self_referencing_property
Mar 24, 2026
Merged

Fix self-referencing property (unused like others in this class)#282
Enkidu93 merged 1 commit intomainfrom
fix_self_referencing_property

Conversation

@Enkidu93
Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 commented Mar 24, 2026

Fix a typo introduced in #279. This property and some others in this class are unused, so I did not notice. If you'd like I could add tests or remove them.


This change is Reviewable

@Enkidu93 Enkidu93 force-pushed the fix_self_referencing_property branch from 2eaa944 to 3c66561 Compare March 24, 2026 15:03
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.49%. Comparing base (ca37757) to head (3c66561).

Files with missing lines Patch % Lines
machine/translation/translation_result_builder.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         355      355           
  Lines       22834    22834           
=======================================
  Hits        20893    20893           
  Misses       1941     1941           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 merged commit 6ada7ea into main Mar 24, 2026
14 checks passed
@Enkidu93 Enkidu93 deleted the fix_self_referencing_property branch March 24, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants