Implement homograph numbers and improve entry search/sort behavior

[myieye]

Summary

This PR implements homograph number auto-assignment for entries with duplicate headwords and significantly improves entry search and sorting behavior to properly handle morphological tokens and secondary ordering.

Key Changes

Homograph Number Management

• Added HomographNumber property to Entry model to distinguish entries with identical headwords
• Implemented auto-assignment logic in CrdtMiniLcmApi.AssignHomographNumber() that:
  • Groups entries by headword and MorphType.SecondaryOrder
  • Auto-assigns sequential numbers (1, 2, 3...) when creating new entries
  • Promotes existing lone entries from 0 to 1 when a duplicate is created
  • Respects explicitly set homograph numbers

Search and Filtering Improvements

• Morph Token Handling: Search now properly strips morph tokens (prefixes/suffixes) from lexeme forms before matching, while preserving them in headword display
• Citation Form Override: Citation forms now correctly override lexeme forms with morph tokens in search results
• Lexeme Form Matching: Fixed search to match against lexeme forms (not just headwords), enabling discovery of entries where only the lexeme matches the query
• Secondary Order Integration: Sorting now incorporates MorphType.SecondaryOrder to group related morphological variants together

Sorting Enhancements

• Added ApplyHeadwordOrder() method to apply consistent headword-based sorting with secondary order consideration
• Updated ApplyRoughBestMatchOrder() to include secondary order and homograph number in sort criteria
• Search relevance ranking now properly considers:
  • Headword matches vs. other field matches
  • Prefix matches vs. contains matches
  • Match length (shorter is better)
  • Secondary order (for grouping morphological variants)
  • Homograph number (for stable ordering of duplicates)

Data Model Changes

• Added Headword computed property to Entry (pre-computed by backend, populated during finalization)
• Added helper methods: HeadwordWithTokens(), SearchHeadwords(), ComputeHeadwords() in EntryQueryHelpers
• Updated EntrySearchService.FilterAndRank() to use new ranking logic with secondary order support
• Modified Filtering.cs to accept IQueryable<MorphType> for proper secondary order filtering

Test Coverage

• Added comprehensive tests for homograph number auto-assignment
• Added tests verifying morph tokens don't affect sort order
• Added tests for search relevance with secondary order (both FTS and non-FTS)
• Added tests for citation form override behavior
• Added tests for morph token search functionality

API Updates

• Updated EntrySearchService.Filter() to accept WritingSystemId parameter
• Renamed Headword() method to HeadwordText() in various test helpers to distinguish from the new Headword property
• Updated FwData bridge to compute headwords during entry conversion

Notable Implementation Details

• Homograph number assignment uses a single DB query pattern consistent with existing sorting logic
• Morph token stripping is applied only to lexeme form searches, not citation form searches
• Secondary order defaults to Stem's order when an entry's MorphType is not found
• The Headword property is computed by the backend and excluded from strict equality checks in sync tests

https://claude.ai/code/session_01FJj2v135u6KdgVxoK4tRp2

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 27ebdd83-7154-428d-9ce1-453561d9599e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/add-homograph-numbers-V1a05

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}