Make record step mobile friendly#233
Open
markjpratt31 wants to merge 23 commits intosillsdev:developfrom
Open
Conversation
markjpratt31
commented
Mar 26, 2026
markjpratt31
commented
Mar 27, 2026
src/renderer/src/components/PassageDetail/mobile/record/DeleteDialog.tsx
Outdated
Show resolved
Hide resolved
markjpratt31
commented
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the renderer recording workflow to better support mobile layouts (record step + rights recording + version selection), adding dedicated mobile UI components and wiring mobile-specific controls into the existing audio/recording stack.
Changes:
- Add mobile-specific record step UI (new
PassageDetailRecordMobile, mobile rights flow UI, mobile audio version cards/table). - Extend existing recording/audio player components (
MediaRecord,WSAudioPlayer,RecordButton) with mobile modes and extra callbacks. - Add new localization key(s) intended to support “Upload” in the shared strings.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/store/localization/model.tsx | Adds upload to ISharedStrings. |
| src/renderer/src/control/RecordButton.tsx | Adds mobile rendering variants for record controls (incl. rights recording). |
| src/renderer/src/components/WSAudioPlayer.tsx | Adds mobile UI branches for recording/controls, including rights-recording and version/save/delete actions. |
| src/renderer/src/components/SpeakerName.tsx | Adjusts speaker selection/rights UX for mobile. |
| src/renderer/src/components/ProvideRights.tsx | Routes mobile users to a new ProvideRightsMobile component; passes upload into MediaRecord. |
| src/renderer/src/components/PassageRecordDlg.tsx | Adjusts dialog sizing behavior using useMobile. |
| src/renderer/src/components/PassageDetail/mobile/record/ProvideRightsMobile.tsx | New mobile rights-provision UI around VoiceStatement + MediaRecord. |
| src/renderer/src/components/PassageDetail/mobile/record/PassageDetailRecordMobile.tsx | New mobile record-step implementation wiring speaker, upload, versions, and MediaRecord. |
| src/renderer/src/components/PassageDetail/mobile/record/DeleteDialog.tsx | New mobile delete confirmation dialog. |
| src/renderer/src/components/PassageDetail/mobile/record/AudioVersionCard.tsx | New mobile card UI for selecting/playing/downloading versions. |
| src/renderer/src/components/PassageDetail/PassageDetailMobileDetail.tsx | Layout tweak to ensure full-height stacking. |
| src/renderer/src/components/MediaRecord.tsx | Adds mobile branching and passes new props through to WSAudioPlayer. |
| src/renderer/src/components/AudioTab/VersionDlg.tsx | Adds mobile “select version” flow using card selection. |
| src/renderer/src/components/AudioTab/AudioTable.tsx | Adds mobile card-based rendering path. |
| src/renderer/src/business/voice/VoiceStatement.tsx | Adjusts layout/controls for mobile. |
| localization/strings-3u.csv | Attempts to add shared.upload but currently malformed. |
| localization/strings-3.csv | Attempts to add shared.upload but currently malformed. |
| localization/TranscriberAdmin-en-1.2.xliff | Adds shared.upload trans-unit. |
| package.json / package-lock.json | Bumps @fingerprintjs/fingerprintjs to ^5.1.0 and updates lockfile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/renderer/src/components/PassageDetail/mobile/record/DeleteDialog.tsx
Outdated
Show resolved
Hide resolved
src/renderer/src/components/PassageDetail/mobile/record/DeleteDialog.tsx
Outdated
Show resolved
Hide resolved
src/renderer/src/components/PassageDetail/mobile/record/ProvideRightsMobile.tsx
Outdated
Show resolved
Hide resolved
f94ec4d to
3ade38f
Compare
3ade38f to
c141212
Compare
39507f4 to
eb957b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for letting me be a part of this awesome project!
Spec: https://balsamiq.cloud/sjstsj5/ptdhbh3/rB474