Skip to content

Make record step mobile friendly#233

Open
markjpratt31 wants to merge 23 commits intosillsdev:developfrom
markjpratt31:markpratt/record
Open

Make record step mobile friendly#233
markjpratt31 wants to merge 23 commits intosillsdev:developfrom
markjpratt31:markpratt/record

Conversation

@markjpratt31
Copy link
Copy Markdown

@markjpratt31 markjpratt31 commented Mar 26, 2026

Thank you for letting me be a part of this awesome project!

Spec: https://balsamiq.cloud/sjstsj5/ptdhbh3/rB474

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the renderer recording workflow to better support mobile layouts (record step + rights recording + version selection), adding dedicated mobile UI components and wiring mobile-specific controls into the existing audio/recording stack.

Changes:

  • Add mobile-specific record step UI (new PassageDetailRecordMobile, mobile rights flow UI, mobile audio version cards/table).
  • Extend existing recording/audio player components (MediaRecord, WSAudioPlayer, RecordButton) with mobile modes and extra callbacks.
  • Add new localization key(s) intended to support “Upload” in the shared strings.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
src/renderer/src/store/localization/model.tsx Adds upload to ISharedStrings.
src/renderer/src/control/RecordButton.tsx Adds mobile rendering variants for record controls (incl. rights recording).
src/renderer/src/components/WSAudioPlayer.tsx Adds mobile UI branches for recording/controls, including rights-recording and version/save/delete actions.
src/renderer/src/components/SpeakerName.tsx Adjusts speaker selection/rights UX for mobile.
src/renderer/src/components/ProvideRights.tsx Routes mobile users to a new ProvideRightsMobile component; passes upload into MediaRecord.
src/renderer/src/components/PassageRecordDlg.tsx Adjusts dialog sizing behavior using useMobile.
src/renderer/src/components/PassageDetail/mobile/record/ProvideRightsMobile.tsx New mobile rights-provision UI around VoiceStatement + MediaRecord.
src/renderer/src/components/PassageDetail/mobile/record/PassageDetailRecordMobile.tsx New mobile record-step implementation wiring speaker, upload, versions, and MediaRecord.
src/renderer/src/components/PassageDetail/mobile/record/DeleteDialog.tsx New mobile delete confirmation dialog.
src/renderer/src/components/PassageDetail/mobile/record/AudioVersionCard.tsx New mobile card UI for selecting/playing/downloading versions.
src/renderer/src/components/PassageDetail/PassageDetailMobileDetail.tsx Layout tweak to ensure full-height stacking.
src/renderer/src/components/MediaRecord.tsx Adds mobile branching and passes new props through to WSAudioPlayer.
src/renderer/src/components/AudioTab/VersionDlg.tsx Adds mobile “select version” flow using card selection.
src/renderer/src/components/AudioTab/AudioTable.tsx Adds mobile card-based rendering path.
src/renderer/src/business/voice/VoiceStatement.tsx Adjusts layout/controls for mobile.
localization/strings-3u.csv Attempts to add shared.upload but currently malformed.
localization/strings-3.csv Attempts to add shared.upload but currently malformed.
localization/TranscriberAdmin-en-1.2.xliff Adds shared.upload trans-unit.
package.json / package-lock.json Bumps @fingerprintjs/fingerprintjs to ^5.1.0 and updates lockfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gtryus gtryus force-pushed the markpratt/record branch from 39507f4 to eb957b0 Compare March 27, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants