Skip to content

[Docker] Ignore appsettings.Development.json in the backend#4226

Open
imnasnainaec wants to merge 1 commit intomasterfrom
backend-docker-ignore-dev
Open

[Docker] Ignore appsettings.Development.json in the backend#4226
imnasnainaec wants to merge 1 commit intomasterfrom
backend-docker-ignore-dev

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented Mar 27, 2026

This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Improved Docker build configuration to exclude development settings from being included in the container image.

@imnasnainaec imnasnainaec self-assigned this Mar 27, 2026
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Mar 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

📝 Walkthrough

Walkthrough

Added appsettings.Development.json to the Backend .dockerignore file, preventing the development configuration file from being included in the Docker build context and final container image.

Changes

Cohort / File(s) Summary
Docker Configuration
Backend/.dockerignore
Added appsettings.Development.json to exclude development settings from Docker builds, ensuring development-specific configuration is not copied into container images.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A little file we tuck away,
Development settings hidden from the fray,
Into the Docker image they shall not creep,
Our secrets safe, in ignorance they sleep! 📦✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding appsettings.Development.json to the Docker ignore file in the backend.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backend-docker-ignore-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.23%. Comparing base (e0c5628) to head (6509657).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4226       +/-   ##
===========================================
+ Coverage   75.94%   87.23%   +11.29%     
===========================================
  Files         303       57      -246     
  Lines       11352     5078     -6274     
  Branches     1407      620      -787     
===========================================
- Hits         8621     4430     -4191     
+ Misses       2330      506     -1824     
+ Partials      401      142      -259     
Flag Coverage Δ
backend 87.23% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker 🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants