Skip to content

[WordCard, *Completed] Migrate from deprecated Grid#3925

Merged
imnasnainaec merged 3 commits intomasterfrom
grid2g-completed
Aug 13, 2025
Merged

[WordCard, *Completed] Migrate from deprecated Grid#3925
imnasnainaec merged 3 commits intomasterfrom
grid2g-completed

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented Aug 11, 2025

Parts of #3879

Notes for review:

  • In most places, replaced <Grid> with <Grid2>, <Stack>, <Box>, <div>, or nothing, as fit the design need.
  • <Stack direction="row"> can be used in place of <Grid2> when we don't want the items in the row to wrap to a second row in a narrow window

Notes for testing:

  • Do a side-by-side visual comparison between this and master (on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited components
  • Try each edited component with various window widths > 350px (we don't support narrower than that)
  • Test *Completed components by clicking a completed goal tile in Data Cleanup under "You've completed:"
    • For MergeDupsCompleted, first go to Data Cleanup > Merge Duplicates, and merge and/or delete words in various combinations
    • For WordCard and ReviewEntriesCompleted, first go to Data Cleanup > Review Entries and edit several entries, including adding multiple semantic domains to a sense
  • Test with a few different UI languages

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.03%. Comparing base (9afcccd) to head (ac8b721).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Buttons/UndoButton.tsx 25.00% 3 Missing ⚠️
src/goals/MergeDuplicates/MergeDupsCompleted.tsx 60.00% 2 Missing ⚠️
src/goals/ReviewEntries/ReviewEntriesCompleted.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3925   +/-   ##
=======================================
  Coverage   74.03%   74.03%           
=======================================
  Files         288      288           
  Lines       10627    10624    -3     
  Branches     1328     1329    +1     
=======================================
- Hits         7868     7866    -2     
+ Misses       2372     2371    -1     
  Partials      387      387           
Flag Coverage Δ
backend 85.43% <ø> (ø)
frontend 65.38% <58.82%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 7 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 13, 2025 18:13
@imnasnainaec imnasnainaec merged commit efbfe3c into master Aug 13, 2025
18 of 19 checks passed
@imnasnainaec imnasnainaec deleted the grid2g-completed branch August 13, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants