[WordCard, *Completed] Migrate from deprecated Grid#3925
Merged
imnasnainaec merged 3 commits intomasterfrom Aug 13, 2025
Merged
[WordCard, *Completed] Migrate from deprecated Grid#3925imnasnainaec merged 3 commits intomasterfrom
imnasnainaec merged 3 commits intomasterfrom
Conversation
caf470d to
9d72614
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3925 +/- ##
=======================================
Coverage 74.03% 74.03%
=======================================
Files 288 288
Lines 10627 10624 -3
Branches 1328 1329 +1
=======================================
- Hits 7868 7866 -2
+ Misses 2372 2371 -1
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fd1a777 to
91ea328
Compare
This was referenced Aug 11, 2025
jasonleenaylor
approved these changes
Aug 13, 2025
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 3 of 7 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parts of #3879
Notes for review:
<Grid>with<Grid2>,<Stack>,<Box>,<div>, or nothing, as fit the design need.<Stack direction="row">can be used in place of<Grid2>when we don't want the items in the row to wrap to a second row in a narrow windowNotes for testing:
master(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited components*Completedcomponents by clicking a completed goal tile in Data Cleanup under "You've completed:"WordCardandReviewEntriesCompleted, first go to Data Cleanup > Review Entries and edit several entries, including adding multiple semantic domains to a senseThis change is