[ProjectSettings, SiteSettings] Migrate from deprecated Grid#3863
Merged
imnasnainaec merged 15 commits intomasterfrom Aug 7, 2025
Merged
[ProjectSettings, SiteSettings] Migrate from deprecated Grid#3863imnasnainaec merged 15 commits intomasterfrom
imnasnainaec merged 15 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3863 +/- ##
=======================================
Coverage 74.13% 74.13%
=======================================
Files 288 288
Lines 10606 10614 +8
Branches 1323 1326 +3
=======================================
+ Hits 7863 7869 +6
- Misses 2358 2359 +1
- Partials 385 386 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
approved these changes
Aug 7, 2025
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 10 of 23 files at r1, 5 of 11 files at r2, 7 of 8 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3787
Notes for review:
<Grid>with<Grid2>,<Stack>,<Box>,<div>, or nothing, as fit the design need.<Stack direction="row">can be used in place of<Grid2>when we don't want the items in the row to wrap to a second row in a narrow windowmaster(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited componentsUploadImageandViewImageDialog(respectively):SiteSettingsby logging in with a site admin (https://github.com/sillsdev/TheCombine?tab=readme-ov-file#grant-admin-rights), then click your avatar to open theUserMenuand the top option will be "Site Settings"Screenshot pairs below are before and after
Project Settings > Languages > Analysis > text wrapping
300px


Project Settings > Semantic Domains > Custom Semantic Domains > look at spacing around icons
900px


350px


Site Settings > Users > delete user dialog
Site Settings > Banners
800px


400px


This change is