Skip to content

[Login, Signup, PasswordReset] Migrate from deprecated Grid#3862

Merged
imnasnainaec merged 12 commits intomasterfrom
grid2c-login
Aug 7, 2025
Merged

[Login, Signup, PasswordReset] Migrate from deprecated Grid#3862
imnasnainaec merged 12 commits intomasterfrom
grid2c-login

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented Jun 9, 2025

Part of #3787

Notes for review:

  • In most places, replaced <Grid> with <Grid2>, <Stack>, <div>, or nothing, as fit the design need.
  • <Stack direction="row"> can be used in place of <Grid2> when we don't want the items in the row to wrap to a second row in a narrow window
  • <Card> layout was made more consistent across InvalidLink, Login, Signup, ResetRequest, & PasswordReset
  • Do a side-by-side visual comparison between this and master (on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited components
  • Try each edited component with various window widths > 400px (we don't support narrower than that)
  • Click "Forgot password?" on the Login page to test ResetRequest; initiate a password reset and click the link sent to your email to test PasswordReset; change a character in the token within that url to test InvalidLink
  • Test with a few different UI languages

Screenshots of before'n'after

Signup
Screenshot 2025-06-19 133108
Screenshot 2025-06-19 133128

Login
Screenshot 2025-06-19 132946
Screenshot 2025-06-19 133002

Password reset request
Screenshot 2025-06-19 133023
Screenshot 2025-06-19 133041

Password reset requested
Screenshot 2025-06-19 133402
Screenshot 2025-06-19 133420

Password reset valid token
Screenshot 2025-06-19 134637
Screenshot 2025-06-19 134655

Password reset invalid token
Screenshot 2025-06-19 133306
Screenshot 2025-06-19 133318



This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jun 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

❌ Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.13%. Comparing base (843c541) to head (2756381).
⚠️ Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
src/components/InvalidLink/index.tsx 0.00% 4 Missing ⚠️
src/components/Login/Login.tsx 50.00% 3 Missing ⚠️
src/components/PasswordReset/ResetPage.tsx 50.00% 3 Missing ⚠️
src/components/PasswordReset/Request.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3862      +/-   ##
==========================================
- Coverage   74.17%   74.13%   -0.04%     
==========================================
  Files         288      288              
  Lines       10612    10606       -6     
  Branches     1323     1323              
==========================================
- Hits         7871     7863       -8     
- Misses       2354     2358       +4     
+ Partials      387      385       -2     
Flag Coverage Δ
backend 85.41% <ø> (ø)
frontend 65.57% <45.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec marked this pull request as draft June 10, 2025 20:11
@imnasnainaec imnasnainaec marked this pull request as ready for review June 10, 2025 21:11
@jasonleenaylor
Copy link
Copy Markdown
Contributor

src/components/PasswordReset/ResetPage.tsx line 0 at r3 (raw file):
So you removed the Back to login button from this component?

Copy link
Copy Markdown
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/PasswordReset/ResetPage.tsx line at r3 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

So you removed the Back to login button from this component?

Yes, because I changed it to automatically navigate back to login and just toast the result of the reset.

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r1, 7 of 7 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 1fe94f6 into master Aug 7, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the grid2c-login branch August 7, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants