[Login, Signup, PasswordReset] Migrate from deprecated Grid#3862
[Login, Signup, PasswordReset] Migrate from deprecated Grid#3862imnasnainaec merged 12 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3862 +/- ##
==========================================
- Coverage 74.17% 74.13% -0.04%
==========================================
Files 288 288
Lines 10612 10606 -6
Branches 1323 1323
==========================================
- Hits 7871 7863 -8
- Misses 2354 2358 +4
+ Partials 387 385 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/components/PasswordReset/ResetPage.tsx line at r3 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
So you removed the Back to login button from this component?
Yes, because I changed it to automatically navigate back to login and just toast the result of the reset.
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 2 of 7 files at r1, 7 of 7 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Part of #3787
Notes for review:
<Grid>with<Grid2>,<Stack>,<div>, or nothing, as fit the design need.<Stack direction="row">can be used in place of<Grid2>when we don't want the items in the row to wrap to a second row in a narrow window<Card>layout was made more consistent acrossInvalidLink,Login,Signup,ResetRequest, &PasswordResetmaster(on QA) to make sure appearance is (roughly) the same or (subjectively) improved on all edited componentsResetRequest; initiate a password reset and click the link sent to your email to testPasswordReset; change a character in the token within that url to testInvalidLinkScreenshots of before'n'after
Signup


Login


Password reset request


Password reset requested


Password reset valid token


Password reset invalid token


This change is