Open
Conversation
Signed-off-by: Appu Goundan <appu@google.com>
aaronlew02
reviewed
Mar 6, 2026
Comment on lines
+136
to
+149
| var resp = httpRequest.execute(); | ||
| if (resp.getStatusCode() != 200) { | ||
| throw new CertificateException( | ||
| String.format( | ||
| Locale.ROOT, | ||
| "bad response from fulcio @ '%s' : %s", | ||
| endpoint, | ||
| resp.parseAsString())); | ||
| } | ||
| responseJson = resp.parseAsString(); | ||
| } catch (IOException e) { | ||
| throw new CertificateException("Failed to request signing certificate from fulcio", e); | ||
| } | ||
|
|
Collaborator
Collaborator
|
This looks great, though I'm a bit concerned about duplication between the gRPC and HTTP client implementations as well as their tests. For the clients, WDYT about extracting common logic into a utility class or moving it into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seem like private deployments don't want to expose the grpc endpoint, so provide the http client.
Release Note
Documentation