Skip to content

Add Lua method to allow verbose channel data on User fired Events#2999

Open
bundasmanu wants to merge 5 commits intosignalwire:masterfrom
bundasmanu:allow_to_pass_verbose_data_on_custom_user_events
Open

Add Lua method to allow verbose channel data on User fired Events#2999
bundasmanu wants to merge 5 commits intosignalwire:masterfrom
bundasmanu:allow_to_pass_verbose_data_on_custom_user_events

Conversation

@bundasmanu
Copy link
Copy Markdown

Description

Included a new lua method to allow verbose channel data in user fire events.
verbose-channel-events at this point only works for FS internal fired events, but could be useful to apply that in user fired events.

Usage example:

event:verboseChannelData() -- will try to use `Unique-ID` to get channel
event:verboseChannelData("call-uuid") -- will check Event header `call-uuid` to get the channel

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Code cleanup / refactor

Testing

  • Added/updated unit tests
  • Tested manually
  • Tested with live SignalWire credentials (if applicable)

Manual tests were applied.

  • Without argument, will use Unique-ID to get channel and populate info;
    • If Unique-ID is not available, and no argument is provided, the event will not contain channel data;
  • Passing argument, indicating the event header to be used to get the channel uuid;
    • If channel exist, verbose is applied;

Checklist

  • I have read the CONTRIBUTING guidelines
  • My code follows the project's style guidelines
  • I have added tests for my changes (if applicable)
  • I have updated documentation (if applicable)
  • All existing tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant