Remove some unused classes#14636
Closed
JesseWeinstein wants to merge 5 commits intosignalapp:mainfrom
Closed
Conversation
JesseWeinstein
changed the title
The use of it was removed (silently) in Mar 2024 in commit: signalapp@591d499 which removed two unused methods that used it. The uses of those methods were removed back in Jan 2023 in signalapp@b4a3459
JesseWeinstein
force-pushed
the
remove_unused_file
branch
from
68016d7 to
c7d2e08
Compare
Contributor
|
Thanks for the contribution! This change will be included in v8.3. |
Contributor
Author
|
Committed in 30426ee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
As I was looking thru the repo, I noticed that LogSecretProvider was unused. Tracing back in the history, it's use was removed when PersistentLogger was converted to Kotlin, in commit 7419da7 back in 2021.
I then decided to look for other such files.