fix(date-range-filter): fix range selection, display message when inc…#1891
Open
fix(date-range-filter): fix range selection, display message when inc…#1891
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a "Select end date" label to the date range filter preview for cases where the end date is not yet selected. The component now includes a configurable input for this label and prevents range updates until both dates are chosen. Unit tests have been updated with a new test case and component harnesses to verify the preview text. I have no feedback to provide.
dr-itz
force-pushed
the
fix/date-range-filter-range
branch
from
a963e02 to
89bad2a
Compare
dr-itz
force-pushed
the
fix/date-range-filter-range
branch
from
89bad2a to
9dd2062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…omplete
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: