fix(datepicker): correctly classify noon as PM in si-timepicker merid…#1887
Open
fix(datepicker): correctly classify noon as PM in si-timepicker merid…#1887
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects the meridian logic in the timepicker component to ensure that 12:00 PM (noon) is correctly identified as PM instead of AM. It also includes a new unit test to verify this behavior. Feedback was provided to optimize performance by only emitting the meridian change event when the value actually changes, which helps avoid redundant change detection cycles.
…ian detection fixes #1886
spliffone
force-pushed
the
fix/timepicker-meridian-selection
branch
from
fa1e2c9 to
3c627b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ian detection
fixes #1886
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: