fix(pills-input): show correct cursor when hovering delete#1884
Draft
fix(pills-input): show correct cursor when hovering delete#1884
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the accessibility of the SiInputPillComponent by converting the delete element from a span to a button and adding an ARIA label. It also introduces a new unit test suite for the component. Feedback includes correcting import paths for testing utilities in the spec file, ensuring proper change detection cycles are triggered in tests, and localizing the hardcoded "Remove" label to support internationalization.
ljanner
force-pushed
the
fix/pills-input-a11y
branch
from
f978ccb to
d758b8b
Compare
ljanner
changed the title
ljanner
force-pushed
the
fix/pills-input-a11y
branch
from
d758b8b to
63bcb3a
Compare
ljanner
changed the title
ljanner
force-pushed
the
fix/pills-input-a11y
branch
from
63bcb3a to
eaf2faf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #888
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: