refactor(theme): use relative units for dropdowns#1880
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new menu example and updates dropdown styles to use dynamic sizing and the :is() selector. Feedback focuses on restoring the !default flag to a theme variable to allow for overrides, removing unsupported text content from a menu divider, and adhering to the style guide by importing standalone components instead of an NgModule.
a418e86 to
bd1eb15
Compare
spliffone
left a comment
There was a problem hiding this comment.
With the current approach the si-select template is limited to one line, do we have the changes to fix this behaviour too?
bd1eb15 to
639a444
Compare
done |
639a444 to
e0e8884
Compare
nope, too much is broken |
e0e8884 to
ca96bde
Compare
reverted, too much for this PR and out of scope anyway |
ca96bde to
3c60720
Compare
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: