Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a subHeading property to the SiDashboardCardComponent, including template updates, styling for the heading container, and corresponding unit tests. Review feedback identifies that the card header's visibility condition needs to include the new subHeading to prevent it from being hidden when no primary heading is present. Additionally, it is recommended to conditionally apply top padding to the subheading only when a primary heading exists to maintain correct visual alignment.
ljanner
force-pushed
the
fix/dashboard-card-subHeading
branch
2 times, most recently
from
e027f27 to
85624ee
Compare
Aligned the heading section with si-card. The subHeading input was inherited from `SiCardBaseDirective` but not rendered in the dashboard card template. Resolves #1874
ljanner
force-pushed
the
fix/dashboard-card-subHeading
branch
from
85624ee to
df09b72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligned the heading section with si-card. The subHeading input was inherited from
SiCardBaseDirectivebut not rendered in the dashboard card template.Resolves #1874
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: