docs(tabs): show tooltip in si-tabs-icons example#1872
Open
docs(tabs): show tooltip in si-tabs-icons example#1872
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds tooltips to the tab icons in the si-tabs example by importing the SiTooltipDirective and applying it to the si-tab components. A suggestion was made to bind the [isDisabled] input to the presence of the tooltip text to avoid creating unnecessary tooltip instances with ARIA attributes when the content is empty.
spliffone
force-pushed
the
docs/icon-tab-with-tooltip
branch
from
402b1de to
8455c9c
Compare
spliffone
force-pushed
the
docs/icon-tab-with-tooltip
branch
from
8455c9c to
b253f01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend si-tabs-icons example to show tooltips
See https://code.siemens.com/simpl/simpl-element/-/work_items/2691
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: