refactor(wizard): use relative units for wizard sizing#1848
Open
refactor(wizard): use relative units for wizard sizing#1848
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates various pixel-based dimensions in the wizard component to use rem units for better scalability. A review comment correctly identified that the border-radius calculation was imprecise and suggested using 50% to ensure a perfect circle regardless of the element's size.
dr-itz
reviewed
Apr 10, 2026
dr-itz
requested changes
Apr 10, 2026
9ba4477 to
e1de214
Compare
dr-itz
reviewed
Apr 15, 2026
d0d2a7f to
4be8220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://code.siemens.com/simpl/simpl-element/-/work_items/4
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: