Skip to content

refactor(wizard): use relative units for wizard sizing#1848

Open
spliffone wants to merge 1 commit intomainfrom
feat/wizard-relative-sizing
Open

refactor(wizard): use relative units for wizard sizing#1848
spliffone wants to merge 1 commit intomainfrom
feat/wizard-relative-sizing

Conversation

@spliffone
Copy link
Copy Markdown
Member

@spliffone spliffone commented Apr 9, 2026

@spliffone spliffone requested review from a team as code owners April 9, 2026 20:09
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various pixel-based dimensions in the wizard component to use rem units for better scalability. A review comment correctly identified that the border-radius calculation was imprecise and suggested using 50% to ensure a perfect circle regardless of the element's size.

Comment thread projects/element-ng/wizard/si-wizard.component.scss
Comment thread projects/element-ng/wizard/si-wizard.component.scss Outdated
@spliffone spliffone force-pushed the feat/wizard-relative-sizing branch 3 times, most recently from 9ba4477 to e1de214 Compare April 13, 2026 09:11
@spliffone spliffone added the enhancement Topics that make the project better label Apr 13, 2026
@spliffone spliffone added this to the 49.x milestone Apr 13, 2026
Comment thread projects/element-ng/wizard/si-wizard.component.ts Outdated
@spliffone spliffone force-pushed the feat/wizard-relative-sizing branch from d0d2a7f to 4be8220 Compare April 16, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Topics that make the project better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants