Skip to content

fix #805 edit jpg can not refresh #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
takeseem wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #805 edit jpg can not refresh #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bin/shutter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4093,6 +4093,12 @@ sub STARTUP {

if ($event eq 'deleted') {

my $v = $session_screens{$key};
if ($v && -e $v->{'giofile'}->get_path) {
print "deleted - $key exists ignored\n" if $sc->get_debug;
Copy link
Member

@DarthGandalf DarthGandalf Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this sentence means

Copy link
Member

@Photon89 Photon89 Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither, it does some magic! 😃

Copy link
Author

@takeseem takeseem Mar 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because save do $exiftool->WriteInfo($filename); in os is mv

  1. create a tmp file
  2. mv tmp $filename
    os will notify event: deleted, in fact the $filename is not deleted, it still exist in os, just innode changed.

Copy link
Member

@Photon89 Photon89 Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After asking the AI, I think this makes sense. The return line seems to prevent that the file is considered as deleted and thus not updated any more.

return;
}

$handle->cancel;

if (exists $session_screens{$key}) {
Expand Down
Loading