Skip to content

feat: migrated dylint api to latest version #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maximedrn wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: migrated dylint api to latest version #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4517814
feat: enhanced ci workflow
maximedrn Feb 20, 2026
e2dc589
fix: migrate lint emission from span_lint to emit_span_lint across al…
maximedrn Mar 9, 2026
216b302
chore: remove panic_usage lint (too complex to maintain)
maximedrn Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: Continuous Integration

on:
push:
branches: [master]
branches:
- master
pull_request:

concurrency:
Expand All @@ -21,19 +22,23 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6
- name: Checkout repository
uses: actions/checkout@v6

- uses: dtolnay/rust-toolchain@v1
- name: Set up Rust toolchain
uses: dtolnay/rust-toolchain@v1
with:
toolchain: nightly
components: rustfmt, clippy, rustc-dev, rust-src, llvm-tools-preview

- name: Ensure cargo in PATH
run: echo "$HOME/.cargo/bin" >> $GITHUB_PATH

- uses: Swatinem/rust-cache@v2
- name: Cache Rust dependencies
uses: Swatinem/rust-cache@v2

- uses: cargo-bins/cargo-binstall@main
- name: Install cargo-binstall
uses: cargo-bins/cargo-binstall@main

- name: Install dependencies
run: |
Expand All @@ -44,5 +49,5 @@ jobs:
cargo-dylint \
dylint-link

- name: Run CI
- name: Run continuous integration tasks
run: cargo make ci
95 changes: 50 additions & 45 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 1 addition & 6 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
[workspace]
members = [
"rules/missing_type",
"rules/unsafe_usage",
"rules/panic_usage",
"rules/indexing_usage",
]
members = ["rules/missing_type", "rules/unsafe_usage", "rules/indexing_usage"]
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workspace member list drops rules/panic_usage, effectively removing the panic_usage Dylint rule from the repo. This is a functional change beyond a Dylint API migration and currently leaves docs inconsistent (the root README still documents security_panic_usage). If the rule is intended to stay, it should be migrated to the new API and kept in the workspace; if it’s intentionally removed, please also update/remove the corresponding documentation and any references to the lint/rule name.

Copilot uses AI. Check for mistakes.
resolver = "2"

[workspace.metadata.dylint]
Expand Down
Loading
Loading