feat: add ForbidHardcodedCredentialsRule to detect hardcoded credentials#30
Open
Martin Bens (SpiGAndromeda) wants to merge 4 commits intomainfrom
Open
feat: add ForbidHardcodedCredentialsRule to detect hardcoded credentials#30Martin Bens (SpiGAndromeda) wants to merge 4 commits intomainfrom
Martin Bens (SpiGAndromeda) wants to merge 4 commits intomainfrom
Conversation
Implements a new PHPStan rule that detects hardcoded credentials (passwords, API keys, secrets, tokens) in array definitions and encourages using environment variables instead.
Martin Bens (SpiGAndromeda)
requested a review
from Michael Telgmann (mitelg)
Michael Telgmann (mitelg)
requested changes
Apr 13, 2026
| } | ||
|
|
||
| $value = $node->value->value; | ||
| if ($value === '' || $value === '0' || str_starts_with($value, '%') || str_contains($value, 'env(')) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ($value === '' || $value === '0' || str_starts_with($value, '%') || str_contains($value, 'env(')) { | |
| if ($value === '' || str_starts_with($value, '%') || str_contains($value, 'env(')) { |
|
|
||
| public function getNodeType(): string | ||
| { | ||
| return ArrayItem::class; |
Contributor
There was a problem hiding this comment.
why array items? shouldn't this check on strings?
| } | ||
|
|
||
| return [ | ||
| RuleErrorBuilder::message('Possible hardcoded credentials detected. Use environment variables.') |
Contributor
There was a problem hiding this comment.
why hinting to env variables? what is the audience for this error? plugin developers or maintainer of a project in GitHub or so?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.