Skip to content

fix: Pin NPM and Node versions for Eslint #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soner (shyim) merged 1 commit into from
May 5, 2026
Merged

fix: Pin NPM and Node versions for Eslint #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eslint/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,23 +68,23 @@ runs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: "20.x"
node-version: "24.x"

- name: Install admin deps
shell: bash
if: ${{ inputs.forceInstallAdminDeps || contains(inputs.projectPath, 'administration') }}
run: npm ci --no-audit --no-fund --prefer-offline --prefix "src/Administration/Resources/app/administration"
run: npx npm@11.8.0 ci --no-audit --no-fund --prefer-offline --prefix "src/Administration/Resources/app/administration"

- name: Install storefront deps
shell: bash
if: ${{ inputs.forceInstallStorefrontDeps || contains(inputs.projectPath, 'storefront') }}
run: npm ci --no-audit --no-fund --prefer-offline --prefix "src/Storefront/Resources/app/storefront"
run: npx npm@11.8.0 ci --no-audit --no-fund --prefer-offline --prefix "src/Storefront/Resources/app/storefront"

- name: Install Plugin Dependencies
shell: bash
run: npm install --no-audit --no-fund --prefer-offline --prefix "custom/plugins/${{ inputs.extensionName }}/${{ inputs.projectPath }}"
run: npx npm@11.8.0 install --no-audit --no-fund --prefer-offline --prefix "custom/plugins/${{ inputs.extensionName }}/${{ inputs.projectPath }}"

- name: Run Lint command
shell: bash
working-directory: custom/plugins/${{ inputs.extensionName }}/${{ inputs.projectPath }}
run: npm run ${{ inputs.npmLintCmd }}
run: npx npm@11.8.0 run ${{ inputs.npmLintCmd }}