Skip to content

feat: support wide screens#597

Open
Björn Meyer (BrocksiNet) wants to merge 1 commit into
mainfrom
feat/support-wide-screens
Open

feat: support wide screens#597
Björn Meyer (BrocksiNet) wants to merge 1 commit into
mainfrom
feat/support-wide-screens

Conversation

@BrocksiNet
Copy link
Copy Markdown
Contributor

No description provided.

@bojanrajh
Copy link
Copy Markdown
Contributor

For readability reasons, it's recommended to keep line length below 70 characters. We're at 85 at the moment, close to 100 if you also count spaces, at 768px content width (even 944px when there's no outline on the right). Bringing this to 1600px would mean close to 200 characters per line, far exceeding the recommended value. I could see increasing the value for a few percents if absolutely needed.

@BrocksiNet
Copy link
Copy Markdown
Contributor Author

Maybe we find a good balance... because diagrams, tables, and code blocks need more space.

How many people are using the docs on desktop?

So, a slight increase (+5-15%) and maybe some extra styling for diagrams, tables, and code would be fine for you?

@Isengo1989
Copy link
Copy Markdown
Contributor

The majority is using desktop afaik. I am also a fan of more whitespace usage, but I see the point of readability. Also thats how almost every docs tool ships with, so I guess there is a reason behind it. I am fine with a slight increase if it helps, maybe there is a smooth way for just the 3 mentioned types.

@bojanrajh
Copy link
Copy Markdown
Contributor

Björn Meyer (@BrocksiNet) Can we talk about specific examples? I guess I would be okay with using 100% or custom width for some pages or sections, if that's required by that page.

For example, we have a <span class="pre-table --sticky"></span> helper for sticky headers in this table. We could also introduce a pageClass which would then set custom max-width for .VPDoc .container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants