Skip to content

fix redirects within imageResizer #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitek-rostislav merged 2 commits into from
Feb 24, 2026
Merged

fix redirects within imageResizer #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e24f68
fix instructions in tests/README.md
vitek-rostislav Feb 21, 2026
c260070
nginx.yaml: pass forwarded scheme/host to imageResizer fastcgi
vitek-rostislav Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kubernetes/configmap/nginx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,9 @@ data:
fastcgi_pass php-upstream;
include fastcgi_params;
fastcgi_param SCRIPT_FILENAME $realpath_root/imageResizer.php;
fastcgi_param HTTPS $http_x_forwarded_proto;
fastcgi_param HTTP_HOST $request_host;
fastcgi_param REQUEST_SCHEME $http_x_forwarded_proto;
}

# plain 404 page for missing files accessed via CDN
Expand Down
10 changes: 6 additions & 4 deletions tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,28 @@ Tests for verifying Kubernetes manifest generation produces expected output.

```bash
# Run all tests
docker run --rm -v $(pwd):/workspace -w /workspace \
docker run --rm --user "$(id -u):$(id -g)" -v "$(pwd)":/workspace -w /workspace \
shopsys/kubernetes-buildpack:2.0 \
./tests/run-tests.sh

# Run specific scenario
docker run --rm -v $(pwd):/workspace -w /workspace \
docker run --rm --user "$(id -u):$(id -g)" -v "$(pwd)":/workspace -w /workspace \
shopsys/kubernetes-buildpack:2.0 \
./tests/run-tests.sh basic-production

# Update expected files after intentional changes
docker run --rm -v $(pwd):/workspace -w /workspace \
docker run --rm --user "$(id -u):$(id -g)" -v "$(pwd)":/workspace -w /workspace \
shopsys/kubernetes-buildpack:2.0 \
./tests/run-tests.sh --update

# List available scenarios
docker run --rm -v $(pwd):/workspace -w /workspace \
docker run --rm --user "$(id -u):$(id -g)" -v "$(pwd)":/workspace -w /workspace \
shopsys/kubernetes-buildpack:2.0 \
./tests/run-tests.sh --list
```

Using `--user "$(id -u):$(id -g)"` ensures generated files are owned by your local user instead of `root`.

## Options

```
Expand Down
3 changes: 3 additions & 0 deletions tests/scenarios/basic-production/expected/webserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,9 @@ data:
fastcgi_pass php-upstream;
include fastcgi_params;
fastcgi_param SCRIPT_FILENAME $realpath_root/imageResizer.php;
fastcgi_param HTTPS $http_x_forwarded_proto;
fastcgi_param HTTP_HOST $request_host;
fastcgi_param REQUEST_SCHEME $http_x_forwarded_proto;
}

# plain 404 page for missing files accessed via CDN
Expand Down
3 changes: 3 additions & 0 deletions tests/scenarios/development-single-domain/expected/webserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ data:
fastcgi_pass php-upstream;
include fastcgi_params;
fastcgi_param SCRIPT_FILENAME $realpath_root/imageResizer.php;
fastcgi_param HTTPS $http_x_forwarded_proto;
fastcgi_param HTTP_HOST $request_host;
fastcgi_param REQUEST_SCHEME $http_x_forwarded_proto;
}

# plain 404 page for missing files accessed via CDN
Expand Down
3 changes: 3 additions & 0 deletions tests/scenarios/escaping-env/expected/webserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,9 @@ data:
fastcgi_pass php-upstream;
include fastcgi_params;
fastcgi_param SCRIPT_FILENAME $realpath_root/imageResizer.php;
fastcgi_param HTTPS $http_x_forwarded_proto;
fastcgi_param HTTP_HOST $request_host;
fastcgi_param REQUEST_SCHEME $http_x_forwarded_proto;
}

# plain 404 page for missing files accessed via CDN
Expand Down
3 changes: 3 additions & 0 deletions tests/scenarios/production-with-cloudflare/expected/webserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,9 @@ data:
fastcgi_pass php-upstream;
include fastcgi_params;
fastcgi_param SCRIPT_FILENAME $realpath_root/imageResizer.php;
fastcgi_param HTTPS $http_x_forwarded_proto;
fastcgi_param HTTP_HOST $request_host;
fastcgi_param REQUEST_SCHEME $http_x_forwarded_proto;
}

# plain 404 page for missing files accessed via CDN
Expand Down