Skip to content

🧪 Add test suite for more.py supplementary detectors#99

Open
shon wants to merge 1 commit intomasterfrom
add-test-more-5769455649468651926
Open

🧪 Add test suite for more.py supplementary detectors#99
shon wants to merge 1 commit intomasterfrom
add-test-more-5769455649468651926

Conversation

@shon
Copy link
Owner

@shon shon commented Mar 8, 2026

🎯 What: The testing gap addressed
Created a formal test file test_more.py to test the user agents registered via httpagentparser/more.py. This formalizes tests that previously lived within the if __name__ == '__main__': block of more.py.

📊 Coverage: What scenarios are now tested

  • Tested detect and simple_detect functions for the Jakarta Commons-HttpClient and python-requests user agents defined in more.py.
  • Includes coverage for both detect and simple_detect ensuring both APIs return correct results for these supplementary detectors.
  • It accurately represents current bug/limitation in Jakarta Commons-HttpClient version parsing by adding correct expectation values in the test.

Result: The improvement in test coverage
The code provides automated test coverage for more.py that can now be run alongside the full test suite using standard tooling (python3 -m unittest or python3 tests.py test suite).


PR created automatically by Jules for task 5769455649468651926 started by @shon

Co-authored-by: shon <89816+shon@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant