style: remove photolist from cardset_viewer as it is unused#564
Closed
vil02 wants to merge 1 commit intoshlomif:masterfrom
Closed
style: remove photolist from cardset_viewer as it is unused#564vil02 wants to merge 1 commit intoshlomif:masterfrom
photolist from cardset_viewer as it is unused#564vil02 wants to merge 1 commit intoshlomif:masterfrom
Conversation
Collaborator
|
It may not be referenced, but it does exist for a reason. The global photolist is written to hold references to every tkinter PhotoImage that gets created, so they remain alive, and don't get garbage collected. If it's removed, the image references will be lost when the show_cardset method finishes, and none of the images would show in the viewer. So removing it would break the cardset viewer. |
Contributor
Author
|
Thanks for clarifying that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
photolistis nowhere referenced. I think it should be removed.