Skip to content

Fixes #223 : remove incompatible numpy pin from webui requirements#224

Merged
shiyu-coder merged 2 commits intoshiyu-coder:masterfrom
randyy179:codex/fix-webui-python312-deps
Apr 13, 2026
Merged

Fixes #223 : remove incompatible numpy pin from webui requirements#224
shiyu-coder merged 2 commits intoshiyu-coder:masterfrom
randyy179:codex/fix-webui-python312-deps

Conversation

@randyy179
Copy link
Copy Markdown
Contributor

@randyy179 randyy179 commented Mar 10, 2026

Copilot AI review requested due to automatic review settings March 10, 2026 03:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an incompatible NumPy version pin from the Web UI dependency set to make webui/requirements.txt installable again alongside pandas==2.2.2, including on Python 3.12.

Changes:

  • Removed numpy==1.24.3 from webui/requirements.txt to resolve the unsatisfiable pandas/NumPy constraints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread webui/requirements.txt
@@ -1,7 +1,6 @@
flask==2.3.3
flask-cors==4.0.0
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webui/app.py and webui/run.py import NumPy directly, but webui/requirements.txt no longer lists numpy as an explicit dependency. Even though pandas currently pulls NumPy transitively, this makes the Web UI’s direct dependency set unclear and can break installs that don’t resolve transitive deps. Consider adding numpy back without the incompatible hard pin (or with a lower-bound consistent with pandas’ requirements).

Suggested change
flask-cors==4.0.0
flask-cors==4.0.0
numpy>=1.22.4

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. NumPy is a direct dependency because both webui/app.py and webui/run.py import it directly.

I updated webui/requirements.txt to keep NumPy explicit while removing the incompatible hard pin. It now uses a compatible lower bound (numpy>=1.26.0) alongside pandas==2.2.2.

@randyy179 randyy179 closed this Mar 10, 2026
@randyy179 randyy179 reopened this Mar 10, 2026
@shiyu-coder shiyu-coder merged commit 05b75b6 into shiyu-coder:master Apr 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webui/requirements.txt has unsatisfiable pandas/numpy constraints on Python 3.12

3 participants