Add helper function for truncating strings with an ellipsis#968
Merged
carrythebanner merged 2 commits intoshift-org:mainfrom Mar 20, 2026
Merged
Add helper function for truncating strings with an ellipsis#968carrythebanner merged 2 commits intoshift-org:mainfrom
carrythebanner merged 2 commits intoshift-org:mainfrom
Conversation
…OpenGraph tag and export to GCal
onewheelskyward
approved these changes
Mar 20, 2026
ionous
reviewed
Mar 20, 2026
| text = text.slice(0, -1) + "…"; | ||
| } | ||
| return text; | ||
| }; |
Contributor
There was a problem hiding this comment.
you could do something like this if you wanted to avoid that first substr call that goes unused if the length is small enough
{
if (str.length < maxLength) {
return str;
} else {
// replace the last character with an ellipsis
let text = str.substring(0,maxLength-1) + "…";
return text;
}
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use for OpenGraph tag and export to Google Calendar.