[PoC] inspector for EditableTree with transaction handling#22
Draft
sharptrip wants to merge 9 commits into
Draft
[PoC] inspector for EditableTree with transaction handling#22sharptrip wants to merge 9 commits into
sharptrip wants to merge 9 commits into
Conversation
This was referenced Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the PoC implementation of the "property inspector" based on the new tree DDS and its EditableTree API.
The new inspector utilises the EditableTree API in a "full blown" manner operating with fields and nodes in a generic way when reading. A complete traverse of the tree could be "unchained" starting debugging from here:
FluidFramework/experimental/PropertyDDS/examples/property-inspector/src/newInspector.tsx
Line 301 in 3468817
In contrast, the code also uses a not yet published "contextually typed API" and "simple assignments", which allows users to change data in a more convenient way:
FluidFramework/experimental/PropertyDDS/examples/property-inspector/src/newInspector.tsx
Lines 138 to 149 in 3468817
You can check the tests in the corresponding PR to get an idea of what it's all about: microsoft#13292
!Attention!
Transaction handling and other features from commits related to the EditableTree API are not yet available (not even as a PR).
Upd.
Note the difference from original transaction handling PR, which is added by this commit
The reason: it seems that EditManager is not ready to support our case.