[POC] inspector for EditableTree#14
Closed
sharptrip wants to merge 5 commits into
Closed
Conversation
Owner
Author
|
new version #17 |
Owner
Author
|
New version #20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the PoC implementation of the "property inspector" based on the new tree DDS and its EditableTree API.
The new inspector utilises the EditableTree API in a "full blown" manner operating with fields and nodes in a generic way. This example starts here:
FluidFramework/experimental/PropertyDDS/examples/property-inspector/src/newInspector.tsx
Line 290 in a14832f
The code also includes a not yet published code implementing "simple assignments", which allows the users to change data in a more convenient way. You can check this test case to get an idea of what it's all about:
FluidFramework/packages/dds/tree/src/test/feature-libraries/editable-tree/editableTree.editing.spec.ts
Line 105 in a14832f
!Attention!
This PR contains some "hacks" of the tree API - the parts, which are not yet publicly available. These are collected in the commit 67c814a. In which form these parts will become available (if any, in general) is an open question, which is out of scope of the current PR.