Changes from Ryan Appel#5
Merged
Merged
Conversation
tomato42
reviewed
Apr 2, 2026
| Signatures are verified in two steps. | ||
| For the first step, the length of the signature must be checked against the parameter set, | ||
| if the signature length does not match the expected signature length for the parameter set, it must be rejected. | ||
| Thenm the signature is verified according to the procedure in |
Owner
Author
|
Thanks!
________________________________
From: Alicja Kario ***@***.***>
Sent: Thursday, April 2, 2026 8:36 AM
To: sfluhrer/ssh-mldsa ***@***.***>
Cc: Scott Fluhrer (sfluhrer) ***@***.***>; State change ***@***.***>
Subject: Re: [sfluhrer/ssh-mldsa] Changes from Ryan Appel (PR #5)
@tomato42 commented on this pull request.
________________________________
In draft-sfluhrer-ssh-mldsa.md<#5?email_source=notifications&email_token=AB5KPWVEJW7Z3WTJEHJOIS34TZNDRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBVGAZTMNJZGI42M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJL3QOJPXEZLWNFSXOX3DNRUWG2Y#discussion_r3027786140>:
@@ -133,7 +136,10 @@ informative:
# Verification Algorithm
- Signatures are verified according to the procedure in
+ Signatures are verified in two steps.
+ For the first step, the length of the signature must be checked against the parameter set,
+ if the signature length does not match the expected signature length for the parameter set, it must be rejected.
+ Thenm the signature is verified according to the procedure in
typo:
should be "Then" not "Thenm"
—
Reply to this email directly, view it on GitHub<#5?email_source=notifications&email_token=AB5KPWQX6ITXARZMYCXEQKL4TZNDRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBVGAZTMNJZGI42M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJPLQOJPXEZLWNFSXOX3ON52GSZTJMNQXI2LPNZZV6Y3MNFRWW#pullrequestreview-4050365929>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB5KPWXZPRZFMGCJYSPGUGL4TZNDRAVCNFSM6AAAAACXHXMUYWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DANJQGM3DKOJSHE>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parts of his changes that I agree with