Skip to content

Make hasher work with symlinks#83

Open
dragetd wants to merge 2 commits intomasterfrom
feature-hasher-symlinks
Open

Make hasher work with symlinks#83
dragetd wants to merge 2 commits intomasterfrom
feature-hasher-symlinks

Conversation

@dragetd
Copy link
Copy Markdown
Member

@dragetd dragetd commented Oct 29, 2019

No description provided.

@dragetd
Copy link
Copy Markdown
Member Author

dragetd commented Oct 29, 2019

@ma-assbrock it needs to be rebased before it can be reviewed.

@dragetd dragetd force-pushed the feature-hasher-symlinks branch from 664edb1 to 91fac0a Compare September 13, 2020 17:06
@dragetd
Copy link
Copy Markdown
Member Author

dragetd commented Sep 13, 2020

I would love if someone helps me writing a test here, because this is a little beyond my go-ngfu. =/

But since I am the only active maintainer, this PR will be also merged right away.

@dragetd dragetd force-pushed the feature-hasher-symlinks branch from eab268a to bdd7b9a Compare September 13, 2020 18:24
Marc-André Aßbrock and others added 2 commits April 14, 2021 15:42
Example output:
```
INFO[0000] Hashing directory.                            hashesFile=x/bundleinfo.json pathToHash=x/ uniqueBundleName=x
INFO[0000] Hash "x/".
WARN[0000] File "x/foo"->"x/x2" is a symlink, will be treated as a regular file/dir.
INFO[0000] Finished hasher.
``

Symlinks with targets not within the hash directory are not allowed and cause a panic.
@dragetd dragetd force-pushed the feature-hasher-symlinks branch from bdd7b9a to 146ecad Compare April 14, 2021 13:45
@dragetd dragetd marked this pull request as ready for review April 14, 2021 13:45
@dragetd dragetd changed the base branch from develop to master August 23, 2021 10:34
@dragetd dragetd requested a review from MMulthaupt December 6, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant