Skip to content

Fix/store crashes 1.32.1#2020

Merged
ThomasSession merged 4 commits intodevfrom
fix/store-crashes-1.32.1
Mar 2, 2026
Merged

Fix/store crashes 1.32.1#2020
ThomasSession merged 4 commits intodevfrom
fix/store-crashes-1.32.1

Conversation

@ThomasSession
Copy link
Collaborator

Fixing crashes from the playstore report:

  • Do not crash the app when the conversation bottomsheet on the home screen does not have a threadId, instead close it right away
  • Clamp values in reaction overlay to avoid crashes
  • onsaveInstanceState can be called before onViewCreated, so access views in there cautiously

Comment on lines +383 to +386
maxOf(
systemInsets.top.toFloat(),
(height - systemInsets.bottom - actualMenuHeight).toFloat()
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one looks identical to maxMenuYInOverlay?

Suggested change
maxOf(
systemInsets.top.toFloat(),
(height - systemInsets.bottom - actualMenuHeight).toFloat()
)
maxMenuYInOverlay

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah they are the same calculation. I have extracted it out of the if/else to make it clearer

@ThomasSession ThomasSession merged commit 2862a22 into dev Mar 2, 2026
5 checks passed
@ThomasSession ThomasSession deleted the fix/store-crashes-1.32.1 branch March 2, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants