Reproduce try_recv_timeout message loss https://github.com/servo/ipc-channel/issues/450#449
Closed
glyn wants to merge 3 commits intoservo:mainfrom
Closed
Reproduce try_recv_timeout message loss https://github.com/servo/ipc-channel/issues/450#449glyn wants to merge 3 commits intoservo:mainfrom
glyn wants to merge 3 commits intoservo:mainfrom
Conversation
When CancelIoEx returns ERROR_NOT_FOUND, the overlapped read has already completed. Previously the buffer was restored without updating its length, so the bytes the kernel read were silently discarded. Call notify_completion instead, which reads the byte count from the OVERLAPPED structure and updates read_buf accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
glyn
changed the title
Contributor
Author
|
Closing this PR as I am not in a position to vouch for the putative fix. See "AI Caveat" in #450 for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.