unit-11: add markdown link check to CI#6
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
link-checkjob to.github/workflows/validate-skills.ymlthat runsgaurav-nelson/github-action-markdown-link-check@v1againstskills/,references/, and root-level docs (README.md,CLAUDE.md,CONTRIBUTING.md,AGENTS.md,CODE_OF_CONDUCT.md).references/**, root*.md, and.markdown-link-check.jsonso link-check runs whenever those change..markdown-link-check.jsonwith conservative defaults: 20s timeout, retry on 429 (2 retries, 30s delay), and accept 200/206/301/302/308/403/405 as alive (403/405 covers hosts that reject HEAD requests).Scope: ignore patterns explained
The config skips four rate-limited / bot-hostile hosts that frequently 429 or timeout in CI and would otherwise cause flaky failures:
developers.facebook.com(Meta WABA docs — aggressive bot protection)developers.google.com(Google RBM / RCS docs — frequent 429s)business.facebook.com(Meta Business — gated, requires auth)www.campaignregistry.com(TCR — slow + flaky for bots)These hosts are heavily linked from skills because the project domain (SMS/WhatsApp/RCS) inherently depends on their docs. Skipping them keeps CI green without sacrificing coverage of the long tail of broken links elsewhere.
Scope: paths not yet included
The unit spec mentioned
evals/**/*.mdand rootplan.md, but neither exists ondevtoday. The actionexit 2s on missing folder-path or file-path entries (verified by reading itsentrypoint.sh), so they're omitted. Add when those land.Test plan
python3 -c "import yaml; yaml.safe_load(...)"parses workflowpython3 -c "import json; json.load(...)"parses configbash scripts/validate-skills.shstill exits 0link-checkjob executing against current skills + references + root docs