groundtruth: tighten waba-embedded-signup against Sent docs snapshot#21
Merged
Conversation
… docs snapshot
Align skill + references with confirmed Sent v3 behavior from
references/_inputs/sent-docs-v3-2026-05-19.md.
SKILL.md
- Replace stale "Unverified claims" with confirmed facts: no public
Embedded Signup endpoint (Channels page is dashboard-only); webhook
envelope is {field, sub_type, timestamp, payload} with sub-types
<field>.<event>; WhatsApp-specific sub-types still need discovery.
- Fix stale /v3/webhooks/{id}/events reference (not in snapshot);
substitute POST /v3/webhooks/{id}/test which is documented.
waba-embedded-signup-spec.md
- Drop ~245 lines of Meta-Graph mirroring (per CLAUDE.md "never mirror
Meta API docs"). Link to Meta's Embedded Signup / Cloud API / FBL
docs instead.
- Confirm Sent surface: no public Embedded Signup endpoint; dashboard
Channels → WhatsApp is the customer-facing surface; /v3/profiles/
{id}/complete is the documented completion endpoint (sensitive,
idempotent, 10/min burst 5); x-api-key is the v3 auth header.
- Document the confirmed webhook envelope and explain how to discover
WhatsApp sub-types empirically.
waba-onboarding-runbook.md
- Rewrite as the dashboard flow per the task spec: KYC + Meta Business
Portfolio pre-flight, Continue Channel Setup, phone selection (hard
to change later), Facebook/Meta login + WABA + permission grant,
Meta payment (separate from Sent billing), completion confirmation,
API credential retrieval from /dashboard/api-keys.
- Anchor failure modes to verified error codes (AUTH_005/006/007).
whatsapp-sender-profile-mapping.md
- Replace invented Profile schema with the real v3 schema (id, name,
icon, description, short_name, role, status, settings).
- Remove invented endpoints DELETE/PATCH /v3/profiles/{id}/channels/
whatsapp and channels.whatsapp.state field (not in snapshot).
- Confirm POST /v3/profiles/{id}/complete; note x-sender-id is
per-profile, dashboard-exposed, v2 legacy.
- Cross-link to sent-skills:sender-profile-architect.
All three reference files now carry the standard grounding header.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Aligns
waba-embedded-signupskill + references with the confirmed Sent v3 docs snapshot atreferences/_inputs/sent-docs-v3-2026-05-19.md.What changed
{field, sub_type, timestamp, payload}is confirmed. Fixed a stale/v3/webhooks/{id}/eventsreference (not in snapshot) to the documentedPOST /v3/webhooks/{id}/test.waba-embedded-signup-spec.md: dropped ~245 lines of Meta-Graph mirroring (perCLAUDE.md"never mirror Meta API docs"). Confirms the Sent surface: dashboard-only Channels page,POST /v3/profiles/{id}/completeas the completion endpoint,x-api-keyas the v3 auth header. Links to Meta docs for Graph specifics.waba-onboarding-runbook.md: rewrote as the dashboard flow per Channel Setup — KYC + Meta Business Portfolio pre-flight, Continue Channel Setup, phone selection (hard to change later), Facebook/Meta login + WABA + permission grant, Meta payment (separate from Sent billing), completion confirmation, API credentials from/dashboard/api-keys. Failure modes anchored to verifiedAUTH_005/006/007error codes.whatsapp-sender-profile-mapping.md: replaced invented Profile schema with the real v3 schema; removed invented endpoints (DELETE/PATCH /v3/profiles/{id}/channels/whatsapp) and the inventedchannels.whatsapp.statefield that aren't in the snapshot; cross-linked tosent-skills:sender-profile-architect.All three reference files carry the standard
<!-- Grounded against ... -->header.Deliberate divergence from the task brief
The task suggested mentioning
GET /v3/webhooks/event-typesfor WhatsApp sub-type discovery. That endpoint is not in the snapshot — only/v3/webhooks/{id}/testand the webhook model'sevent_types/event_filtersfields are documented. I substituted "inspectGET /v3/webhooks+ subscribe broadly and observe" rather than reference an unverified endpoint. Primary source wins.Verification
bash scripts/validate-skills.shexits 0;waba-embedded-signupbody is 166 lines (< 500).🤖 Generated with Claude Code