groundtruth: tighten sender-profile-architect against Sent docs snapshot#16
Merged
Conversation
… snapshot
- sender-profile-data-model.md: rewrite around the verified Profile resource
({id, name, icon, description, short_name, role, status, created_at, settings})
and v3 single-key auth; add Profile -> Channels (SMS/WhatsApp/RCS) -> Webhooks
diagram; cross-link /v3/brands and /v3/brands/{id}/campaigns for 10DLC.
- multi-tenancy-patterns.md: add verified rate-limit tiers (standard 200/min
burst 50, sensitive 10/min burst 5, message Starter 60/Growth 300/Enterprise
custom), idempotency facts (per-customer scope, 24h TTL, ^[a-zA-Z0-9_-]{1,255}$),
and webhook event_filters shape {<parent>: [<sub_type>, ...]}.
- profile-boundary-examples.md: confirm x-sender-id is per-profile (dashboard
legacy) and the Owner/Admin/Billing/Developer role model; correct the
per-department example to reflect a single account-level x-api-key.
- SKILL.md: rewrite Unverified claims around v3 reality (account-level API key,
verified status enum incomplete|pending_review|approved|rejected, verified
webhook payload fields); update description, when-to-use, frontmatter
comment, and example data model accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Grounds the
sender-profile-architectskill and its references againstreferences/_inputs/sent-docs-v3-2026-05-19.md.Changes
references/sender-profile-data-model.md— major rewrite around the verified Profile resource (id,name,icon,description,short_name,role,status,created_at,settings.{default_channel, webhook_url, timezone, language}). Documents that v3 auth is a single account-levelx-api-keyand thatx-sender-idis a per-profile, dashboard-visible v2 legacy identifier. Adds Profile → Channels (SMS / WhatsApp / RCS) → Webhooks diagram. Cross-links/v3/brandsand/v3/brands/{brandId}/campaignsfor SMS 10DLC.references/multi-tenancy-patterns.md— adds the real rate limits (Standard 200/min burst 50, Sensitive 10/min burst 5, Message tiers Starter 60 / Growth 300 / Enterprise custom), idempotency facts (per-customer-account scope, 24 h TTL,^[a-zA-Z0-9_-]{1,255}$), and the webhookevent_filtersshape{<parent>: [<sub_type>, …]}.references/profile-boundary-examples.md— confirmsx-sender-idis per-profile (dashboard, v2 legacy) and documents the Owner / Admin / Billing / Developer org-level role model. Corrects the per-department example (three keys → one shared account-levelx-api-key).SKILL.md— rewrites the "Unverified claims" section against ground truth: API keys are per customer (not per profile); verifiedstatusenum isincomplete | pending_review | approved | rejected; verified webhook payload exposesaccount_id, message_id, channel, inbound_number, outbound_number, template_id. Updates the description, when-to-use, frontmatter comment, and example data model accordingly.Validation
bash scripts/validate-skills.shexits 0 (all 8 skills validated).