chore: add ESLint config and commands for linting JavaScript bindings.#248
Open
victor-linroth-sensmetry wants to merge 1 commit intomainfrom
Open
chore: add ESLint config and commands for linting JavaScript bindings.#248victor-linroth-sensmetry wants to merge 1 commit intomainfrom
victor-linroth-sensmetry wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: victor.linroth.sensmetry <victor.linroth@sensmetry.com>
victor-linroth-sensmetry
force-pushed
the
chore/eslint-for-js-bindings
branch
from
e6cb58f to
db0db0d
Compare
Comment on lines
60
to
62
| - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6 | ||
| with: | ||
| node-version: 24 |
Collaborator
There was a problem hiding this comment.
(unrelated) Is this needed? We don't (AFAIK) care about exact node version, and the runner comes with node and npm preinstalled.
(ubuntu-24.04 comes with node 20, which will be EOL in a month, but this shouldn't concern us)
|
|
||
| - name: ESLint | ||
| run: | | ||
| cd bindings/js |
Collaborator
There was a problem hiding this comment.
Set this for the whole job like we do for Python:
lint:
needs: [plan]
if: needs.plan.outputs.test == 'true'
runs-on: ubuntu-24.04
defaults:
run:
working-directory: bindings/py
andrius-puksta-sensmetry
requested changes
Mar 31, 2026
Collaborator
andrius-puksta-sensmetry
left a comment
andrius-puksta-sensmetry
left a comment
There was a problem hiding this comment.
Add node requirement to JS readme, also explain how to run the linter there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.