Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the deployment flexibility of the Riverst server by introducing explicit support for both CPU and GPU environments. It provides clear mechanisms for configuring the build and runtime for each target, ensuring that users can leverage hardware acceleration when available while maintaining full functionality on CPU-only systems. The changes include updated documentation, Docker integration, and a robust fallback strategy for GPU-dependent components, making the system more adaptable to various deployment scenarios. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a well-structured mechanism for selecting between CPU and GPU deployments, both at build time (via Docker build args and different requirements files) and at runtime (via an environment variable). The changes are consistently applied across Docker configurations, documentation, and application code. The fallback for ONNX-dependent features on CPU builds is a nice touch for robustness. The addition of a new test suite for the device selection logic is also a great improvement. I have one suggestion to improve the reliability of the new tests.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Testing