[UIK-5011][checkbox] rewrite component to ts#2821
Open
slizhevskyv-semrush wants to merge 2 commits intorelease/v17from
Open
[UIK-5011][checkbox] rewrite component to ts#2821slizhevskyv-semrush wants to merge 2 commits intorelease/v17from
slizhevskyv-semrush wants to merge 2 commits intorelease/v17from
Conversation
ilyabrower
reviewed
Mar 27, 2026
| return { | ||
| includeInputProps: [ | ||
| ...inputProps, | ||
| ...(props.includeInputProps ?? []), |
Contributor
There was a problem hiding this comment.
why did you remove this?
| theme: resolveColor(theme), | ||
| size, | ||
| state, | ||
| // keyboardFocused, |
| if (checkboxRef.current) { | ||
| if (indeterminate === undefined) return; | ||
|
|
||
| checkboxRef.current.indeterminate = indeterminate; |
Contributor
There was a problem hiding this comment.
I think, it's better to set Boolean(indeterminate) here...
| if (props.rootDisabled !== props.disabled) { | ||
| if (props.disabled === undefined) return; | ||
|
|
||
| props.hoistDisabled(props.disabled); |
Contributor
There was a problem hiding this comment.
And Boolean(disabled) here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/checkbox
Fixed
Motivation and Context
Nothing changed in how component works. Just rewrite to TS.
How has this been tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist: