fix: add zip bomb protection and QR part limit enforcement#848
Merged
odudex merged 1 commit intoselfcustody:developfrom Apr 7, 2026
Merged
fix: add zip bomb protection and QR part limit enforcement#848odudex merged 1 commit intoselfcustody:developfrom
odudex merged 1 commit intoselfcustody:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #848 +/- ##
========================================
Coverage 97.31% 97.31%
========================================
Files 83 83
Lines 10596 10607 +11
========================================
+ Hits 10311 10322 +11
Misses 285 285 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
LGTM for now |
…dy#843) DeflateIO now enforces a 100KB max decompressed size at the C level, protecting all callers (BBQR and KEF) from zip bomb OOM on K210. pMofN parser validates part_total (1-99) and part_index range. BBQR parser validates part_total >= 1.
odudex
force-pushed
the
input_size_limits
branch
from
0401ec7 to
8d9d62a
Compare
This was referenced Apr 22, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
DeflateIO now enforces a 100KB max decompressed size at the C level, protecting all callers (BBQR and KEF) from zip bomb OOM on K210. pMofN parser validates part_total (1-99) and part_index range. BBQR parser validates part_total >= 1.
Issues C4 and C5 from #843
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?