Remove unreachable code after while true#842
Conversation
tadeubas
force-pushed
the
remove-unreachable-code
branch
from
c9cae16 to
1ee38dc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #842 +/- ##
========================================
Coverage 97.31% 97.31%
========================================
Files 83 83
Lines 10573 10573
========================================
Hits 10289 10289
Misses 284 284 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tadeubas
force-pushed
the
remove-unreachable-code
branch
from
1ee38dc to
a9bf6c0
Compare
|
Forced-push to fix PR with just one removal. Opened an issue on vulture for the false positive: jendrikseipp/vulture#413 |
| while True: | ||
| data = kef_envelope.unseal_ui() | ||
| if data is None: | ||
| # fail if not unsealed |
There was a problem hiding this comment.
Would it be more clear to future readers to break here and still raise ValueError(err) at bottom so that it doesn't look like falling off end of function is possible?
There was a problem hiding this comment.
I was think it was a good idea, but than called AI for help, plz check the response: https://chatgpt.com/share/69c3e205-b8fc-83e9-b278-7894b33fb241
|
Thank you! |
3 participants
What is this PR for?
Remove unreachable code after while true, as pointed out by
vulturewith 100% confidence.Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?