Skip to content

Remove duplicated HEX and OCT digit constants#841

Merged
odudex merged 1 commit intoselfcustody:developfrom
tadeubas:rem_dup_const_digits_hex
Apr 6, 2026
Merged

Remove duplicated HEX and OCT digit constants#841
odudex merged 1 commit intoselfcustody:developfrom
tadeubas:rem_dup_const_digits_hex

Conversation

@tadeubas
Copy link
Copy Markdown
Member

@tadeubas tadeubas commented Mar 25, 2026

What is this PR for?

Remove duplicated HEX and OCT digit constants (were moved to src/krux/pages/mnemonic_loader.py)

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

Did you build the code and tested on device?

  • Yes, build and tested on

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.31%. Comparing base (94760c5) to head (791868d).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #841      +/-   ##
===========================================
- Coverage    97.31%   97.31%   -0.01%     
===========================================
  Files           83       83              
  Lines        10573    10571       -2     
===========================================
- Hits         10289    10287       -2     
  Misses         284      284              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odudex odudex merged commit 756c239 into selfcustody:develop Apr 6, 2026
7 checks passed
@odudex
Copy link
Copy Markdown
Member

odudex commented Apr 6, 2026

Thank you!

@odudex odudex mentioned this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants